fix: fixing data race

This commit is contained in:
2025-09-30 09:59:46 +07:00
parent b092e36987
commit b4e7238b0b
2 changed files with 15 additions and 26 deletions

View File

@@ -1,7 +1,6 @@
package internal package internal
import ( import (
"fmt"
"log" "log"
"time" "time"
@@ -125,7 +124,7 @@ func ReadPump(c *Client, h *Hub) {
} }
if messageType == websocket.TextMessage { if messageType == websocket.TextMessage {
fmt.Printf("Received: %s\n", message) log.Printf("Received: %s\n", message)
} }
} }
} }

View File

@@ -3,7 +3,6 @@ package client
import ( import (
"context" "context"
"fmt" "fmt"
"io"
"log" "log"
"net/url" "net/url"
"strings" "strings"
@@ -235,12 +234,13 @@ func (wsClient *SafeWebsocketClient) connect() error {
}) })
pingCtx, pingCancel := context.WithCancel(context.Background()) pingCtx, pingCancel := context.WithCancel(context.Background())
go wsClient.startPingTicker(pingCtx)
wsClient.mu.WriteHandler(func() error { wsClient.mu.WriteHandler(func() error {
wsClient.cancelFuncs = append(wsClient.cancelFuncs, pingCancel) wsClient.cancelFuncs = append(wsClient.cancelFuncs, pingCancel)
return nil return nil
}) })
go wsClient.startPingTicker(pingCtx)
if wsClient.conn != nil { if wsClient.conn != nil {
wsClient.conn.Close() wsClient.conn.Close()
} }
@@ -260,14 +260,10 @@ func (wsClient *SafeWebsocketClient) connect() error {
return nil return nil
}) })
writer, err := conn.NextWriter(websocket.TextMessage)
if err != nil {
return
}
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
fmt.Println("Writer stopped due to client shutdown") log.Println("Writer stopped due to client shutdown")
return return
case data := <-wsClient.writeChan: case data := <-wsClient.writeChan:
if conn == nil { if conn == nil {
@@ -275,7 +271,8 @@ func (wsClient *SafeWebsocketClient) connect() error {
return return
} }
if _, err := writer.Write(data.Data); err != nil { if err := conn.WriteMessage(int(data.MessageType), data.Data); err != nil {
log.Printf("error on write message: %v\n", err)
wsClient.triggerReconnect() wsClient.triggerReconnect()
return return
} }
@@ -293,44 +290,37 @@ func (wsClient *SafeWebsocketClient) connect() error {
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
fmt.Println("Reader stopped due to client shutdown") log.Println("Reader stopped due to client shutdown")
return return
default: default:
if conn == nil { if conn == nil {
wsClient.triggerReconnect()
return return
} }
if err := conn.SetReadDeadline(time.Now().Add(readDeadline)); err != nil { if err := conn.SetReadDeadline(time.Now().Add(readDeadline)); err != nil {
wsClient.triggerReconnect() log.Printf("error on read deadline: %v\n", err)
fmt.Printf("error on read deadline: %v\n", err)
return return
} }
mt, reader, err := conn.NextReader() messageType, data, err := conn.ReadMessage()
if err != nil { if err != nil {
log.Printf("error on read message: %v\n", err)
wsClient.triggerReconnect() wsClient.triggerReconnect()
return return
} }
if mt != websocket.TextMessage { if messageType != websocket.TextMessage {
continue continue
} }
readerBytes, err := io.ReadAll(reader)
if err != nil {
fmt.Printf("io reader failed: %v\n", err)
wsClient.triggerReconnect()
return
}
select { select {
case wsClient.dataChannel <- readerBytes: case wsClient.dataChannel <- data:
case <-ctx.Done(): case <-ctx.Done():
return return
default: default:
fmt.Println("Data channel full, dropping message") log.Println("Data channel full, dropping message")
} }
} }
} }
}() }()
@@ -458,7 +448,7 @@ func (wsClient *SafeWebsocketClient) Close() error {
wsClient.conn.Close() wsClient.conn.Close()
} }
wsClient.isConnected = false wsClient.isConnected = false
close(wsClient.dataChannel) // close(wsClient.dataChannel)
return nil return nil
} }