fix: fixing memory leak from unbuffered channel

go.mod

@@ -4,4 +4,4 @@ go 1.24.5
 
 require github.com/gorilla/websocket v1.5.3
 
-require git.neurocipta.com/rogerferdinan/custom-rwmutex v1.0.0 // indirect
+require git.neurocipta.com/rogerferdinan/custom-rwmutex v1.0.0

internal/hub.go

@@ -1,7 +1,6 @@
 package internal
 
 import (
-	"fmt"
 	"log"
 	"time"
 
@@ -24,9 +23,9 @@ type Client struct {
 func NewClient(conn *websocket.Conn, subscribedPath string) *Client {
 	return &Client{
 		Conn:           conn,
-		Send:           make(chan []byte, 64),
+		Send:           make(chan []byte, 2),
 		SubscribedPath: subscribedPath,
-		done:           make(chan struct{}),
+		done:           make(chan struct{}, 1),
 	}
 }
 
@@ -39,10 +38,10 @@ type Hub struct {
 
 func NewHub() *Hub {
 	return &Hub{
-		Broadcast:  make(chan []byte),
+		Broadcast:  make(chan []byte, 1),
-		Register:   make(chan *Client),
+		Register:   make(chan *Client, 1),
-		Unregister: make(chan *Client),
+		Unregister: make(chan *Client, 1),
-		Clients:    make(map[*Client]bool),
+		Clients:    make(map[*Client]bool, 1),
 	}
 }
 
@@ -118,14 +117,14 @@ func ReadPump(c *Client, h *Hub) {
 	for {
 		messageType, message, err := c.Conn.ReadMessage()
 		if err != nil {
-			if !websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) {
+			if websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) {
 				log.Printf("WebSocket error: %v", err)
 			}
 			break
 		}
 
 		if messageType == websocket.TextMessage {
-			fmt.Printf("Received: %s\n", message)
+			log.Printf("Received: %s\n", message)
 		}
 	}
 }

v1/client/client.go

@@ -3,7 +3,6 @@ package client
 import (
 	"context"
 	"fmt"
-	"io"
 	"log"
 	"net/url"
 	"strings"
@@ -17,7 +16,7 @@ import (
 
 const (
 	pingPeriod   = 10 * time.Second
-	readDeadline = 10 * time.Second
+	readDeadline = 30 * time.Second
 )
 
 type SafeMap[K comparable, V any] struct {
@@ -69,10 +68,10 @@ func (sm *SafeMap[K, V]) Len() int {
 type MessageType uint
 
 const (
-	MessageTypeText  MessageType = iota + 1
+	MessageTypeText  MessageType = websocket.TextMessage
-	MessageTypePing  MessageType = iota
+	MessageTypePing  MessageType = websocket.PingMessage
-	MessageTypePong  MessageType = iota
+	MessageTypePong  MessageType = websocket.PongMessage
-	MessageTypeClose MessageType = iota
+	MessageTypeClose MessageType = websocket.CloseMessage
 )
 
 type Message struct {
@@ -156,7 +155,7 @@ func (b *SafeWebsocketClientBuilder) Build(ctx context.Context) (*SafeWebsocketC
 		reconnectCh: make(chan struct{}, 1),
 		isConnected: false,
 		doneMap:     NewSafeMap[string, chan struct{}](),
-		writeChan:   make(chan Message),
+		writeChan:   make(chan Message, 1),
 	}
 
 	if b.authenticateFn != nil {
@@ -194,6 +193,7 @@ type SafeWebsocketClient struct {
 	authenticateFn func(*SafeWebsocketClient) error
 
 	writeChan chan Message
+	pongChan  chan error
 }
 
 func (wsClient *SafeWebsocketClient) connect() error {
@@ -221,26 +221,14 @@ func (wsClient *SafeWebsocketClient) connect() error {
 		return fmt.Errorf("failed to connect to %s: %w", wsClient.baseHost, err)
 	}
 
-	conn.SetPingHandler(func(pingData string) error {
-		if err := conn.WriteMessage(websocket.PongMessage, []byte(pingData)); err != nil {
-			if err == websocket.ErrCloseSent {
-				return nil
-			}
-			if netErr, ok := err.(interface{ Timeout() bool }); ok && netErr.Timeout() {
-				return nil
-			}
-			return err
-		}
-		return nil
-	})
-
 	pingCtx, pingCancel := context.WithCancel(context.Background())
-	go wsClient.startPingTicker(pingCtx)
 	wsClient.mu.WriteHandler(func() error {
 		wsClient.cancelFuncs = append(wsClient.cancelFuncs, pingCancel)
 		return nil
 	})
 
+	go wsClient.startPingTicker(pingCtx)
+
 	if wsClient.conn != nil {
 		wsClient.conn.Close()
 	}
@@ -260,23 +248,29 @@ func (wsClient *SafeWebsocketClient) connect() error {
 			return nil
 		})
 
-		writer, err := conn.NextWriter(websocket.TextMessage)
+		var c *websocket.Conn
-		if err != nil {
+		wsClient.mu.ReadHandler(func() error {
-			return
+			c = conn
-		}
+			return nil
+		})
+
 		for {
 			select {
 			case <-ctx.Done():
-				fmt.Println("Writer stopped due to client shutdown")
+				log.Println("Writer stopped due to client shutdown")
 				return
 			case data := <-wsClient.writeChan:
-				if conn == nil {
+				if c == nil {
 					wsClient.triggerReconnect()
 					return
 				}
 
-				if _, err := writer.Write(data.Data); err != nil {
+				if err := c.WriteMessage(int(data.MessageType), data.Data); err != nil {
+					log.Printf("error on write message: %v\n", err)
 					wsClient.triggerReconnect()
+					if data.MessageType == MessageTypePong {
+						wsClient.pongChan <- err
+					}
 					return
 				}
 			}
@@ -290,49 +284,63 @@ func (wsClient *SafeWebsocketClient) connect() error {
 			return nil
 		})
 
+		var c *websocket.Conn
+
+		wsClient.mu.ReadHandler(func() error {
+			c = conn
+			return nil
+		})
+		if c == nil {
+			wsClient.triggerReconnect()
+			return
+		}
 		for {
 			select {
 			case <-ctx.Done():
-				fmt.Println("Reader stopped due to client shutdown")
+				log.Println("Reader stopped due to client shutdown")
 				return
 			default:
-				if conn == nil {
+				if err := c.SetReadDeadline(time.Now().Add(readDeadline)); err != nil {
-					return
+					log.Printf("error on read deadline: %v\n", err)
-				}
-				if err := conn.SetReadDeadline(time.Now().Add(readDeadline)); err != nil {
-					fmt.Printf("error on read deadline: %v\n", err)
 					return
 				}
 
-				mt, reader, err := conn.NextReader()
+				messageType, data, err := c.ReadMessage()
 				if err != nil {
+					log.Printf("error on read message: %v\n", err)
 					wsClient.triggerReconnect()
 					return
 				}
 
-				if mt != websocket.TextMessage {
+				if messageType != websocket.TextMessage {
 					continue
 				}
 
-				readerBytes, err := io.ReadAll(reader)
-				if err != nil {
-					fmt.Printf("io reader failed: %v\n", err)
-					wsClient.triggerReconnect()
-					return
-				}
 				select {
-				case wsClient.dataChannel <- readerBytes:
+				case wsClient.dataChannel <- data:
 				case <-ctx.Done():
 					return
 				default:
-					fmt.Println("Data channel full, dropping message")
+					log.Println("Data channel full, dropping message")
 				}
-
 			}
-
 		}
 	}()
 
+	conn.SetPingHandler(func(pingData string) error {
+		wsClient.writeChan <- Message{
+			MessageType: MessageTypePong,
+			Data:        []byte(pingData),
+		}
+
+		select {
+		case err := <-wsClient.pongChan:
+			return err
+		default:
+		}
+		return nil
+	})
+
 	return nil
 }
 
@@ -348,7 +356,7 @@ func (wsClient *SafeWebsocketClient) startPingTicker(ctx context.Context) {
 		case <-ticker.C:
 			wsClient.writeChan <- Message{
 				MessageType: websocket.PingMessage,
-				Data:        nil,
+				Data:        []byte{},
 			}
 		}
 	}
@@ -417,7 +425,7 @@ func (wsClient *SafeWebsocketClient) reconnectHandler() {
 }
 
 func (wsClient *SafeWebsocketClient) ReconnectChannel() <-chan struct{} {
-	reconnectCh := make(chan struct{})
+	reconnectCh := make(chan struct{}, 1)
 	wsClient.mu.WriteHandler(func() error {
 		wsClient.reconnectChans = append(wsClient.reconnectChans, reconnectCh)
 		return nil
@@ -457,7 +465,7 @@ func (wsClient *SafeWebsocketClient) Close() error {
 		wsClient.conn.Close()
 	}
 	wsClient.isConnected = false
-	close(wsClient.dataChannel)
+	// close(wsClient.dataChannel)
 
 	return nil
 }