Compare commits

...

4 Commits

Author SHA1 Message Date
78a5b21531 fix: fixing websocket error message log 2025-10-03 10:40:46 +07:00
e011931436 fix: messageType typo 2025-10-01 15:09:06 +07:00
70d9a37a4e fix: pong data race 2025-10-01 14:41:23 +07:00
2ab2e07b9b fix: pong not sent 2025-10-01 14:00:22 +07:00
2 changed files with 16 additions and 15 deletions

View File

@@ -117,7 +117,7 @@ func ReadPump(c *Client, h *Hub) {
for { for {
messageType, message, err := c.Conn.ReadMessage() messageType, message, err := c.Conn.ReadMessage()
if err != nil { if err != nil {
if !websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) { if websocket.IsUnexpectedCloseError(err, websocket.CloseGoingAway, websocket.CloseAbnormalClosure) {
log.Printf("WebSocket error: %v", err) log.Printf("WebSocket error: %v", err)
} }
break break

View File

@@ -16,7 +16,7 @@ import (
const ( const (
pingPeriod = 10 * time.Second pingPeriod = 10 * time.Second
readDeadline = 120 * time.Second readDeadline = 30 * time.Second
) )
type SafeMap[K comparable, V any] struct { type SafeMap[K comparable, V any] struct {
@@ -68,10 +68,10 @@ func (sm *SafeMap[K, V]) Len() int {
type MessageType uint type MessageType uint
const ( const (
MessageTypeText MessageType = iota + 1 MessageTypeText MessageType = websocket.TextMessage
MessageTypePing MessageType = iota MessageTypePing MessageType = websocket.PingMessage
MessageTypePong MessageType = iota MessageTypePong MessageType = websocket.PongMessage
MessageTypeClose MessageType = iota MessageTypeClose MessageType = websocket.CloseMessage
) )
type Message struct { type Message struct {
@@ -193,6 +193,7 @@ type SafeWebsocketClient struct {
authenticateFn func(*SafeWebsocketClient) error authenticateFn func(*SafeWebsocketClient) error
writeChan chan Message writeChan chan Message
pongChan chan error
} }
func (wsClient *SafeWebsocketClient) connect() error { func (wsClient *SafeWebsocketClient) connect() error {
@@ -267,6 +268,9 @@ func (wsClient *SafeWebsocketClient) connect() error {
if err := c.WriteMessage(int(data.MessageType), data.Data); err != nil { if err := c.WriteMessage(int(data.MessageType), data.Data); err != nil {
log.Printf("error on write message: %v\n", err) log.Printf("error on write message: %v\n", err)
wsClient.triggerReconnect() wsClient.triggerReconnect()
if data.MessageType == MessageTypePong {
wsClient.pongChan <- err
}
return return
} }
} }
@@ -328,15 +332,12 @@ func (wsClient *SafeWebsocketClient) connect() error {
MessageType: MessageTypePong, MessageType: MessageTypePong,
Data: []byte(pingData), Data: []byte(pingData),
} }
// if err := conn.WriteMessage(websocket.PongMessage, []byte(pingData)); err != nil {
// if err == websocket.ErrCloseSent { select {
// return nil case err := <-wsClient.pongChan:
// } return err
// if netErr, ok := err.(interface{ Timeout() bool }); ok && netErr.Timeout() { default:
// return nil }
// }
// return err
// }
return nil return nil
}) })