Compare commits

..

9 Commits

3 changed files with 194 additions and 35 deletions

View File

@@ -11,7 +11,7 @@ import (
const ( const (
writeWait = 10 * time.Second writeWait = 10 * time.Second
pongWait = 60 * time.Second pongWait = 60 * time.Second
pingPeriod = 55 * time.Second pingPeriod = 25 * time.Second
) )
type Client struct { type Client struct {
@@ -95,7 +95,7 @@ func WritePump(c *Client, h *Hub) {
} }
case <-pingTicker.C: case <-pingTicker.C:
c.Conn.SetWriteDeadline(time.Now().Add(writeWait)) c.Conn.SetWriteDeadline(time.Now().Add(writeWait))
if err := c.Conn.WriteMessage(websocket.PingMessage, nil); err != nil { if err := c.Conn.WriteMessage(websocket.PingMessage, []byte{}); err != nil {
return return
} }
} }

View File

@@ -6,6 +6,7 @@ import (
"log" "log"
"net/url" "net/url"
"strings" "strings"
"sync"
"time" "time"
custom_rwmutex "git.neurocipta.com/rogerferdinan/custom-rwmutex" custom_rwmutex "git.neurocipta.com/rogerferdinan/custom-rwmutex"
@@ -17,12 +18,59 @@ const (
pingPeriod = 10 * time.Second pingPeriod = 10 * time.Second
) )
type SafeMap[K comparable, V any] struct {
m sync.Map
}
func NewSafeMap[K comparable, V any]() *SafeMap[K, V] {
return &SafeMap[K, V]{
m: sync.Map{},
}
}
func (sm *SafeMap[K, V]) Store(key K, value V) {
sm.m.Store(key, value)
}
func (sm *SafeMap[K, V]) Load(key K) (value V, ok bool) {
val, loaded := sm.m.Load(key)
if !loaded {
return *new(V), false
}
return val.(V), true
}
func (sm *SafeMap[K, V]) Delete(key K) {
sm.m.Delete(key)
}
func (sm *SafeMap[K, V]) Range(f func(K, V) bool) {
sm.m.Range(func(key, value any) bool {
k, ok1 := key.(K)
v, ok2 := value.(V)
if !ok1 || !ok2 {
return true
}
return f(k, v)
})
}
func (sm *SafeMap[K, V]) Len() int {
count := 0
sm.Range(func(_ K, _ V) bool {
count++
return true
})
return count
}
type SafeWebsocketClientBuilder struct { type SafeWebsocketClientBuilder struct {
baseHost *string `nil_checker:"required"` baseHost *string `nil_checker:"required"`
basePort *uint16 `nil_checker:"required"` basePort *uint16 `nil_checker:"required"`
path *string path *string
rawQuery *string rawQuery *string
useTLS *bool useTLS *bool
channelSize *int64
} }
func NewSafeWebsocketClientBuilder() *SafeWebsocketClientBuilder { func NewSafeWebsocketClientBuilder() *SafeWebsocketClientBuilder {
@@ -54,34 +102,43 @@ func (b *SafeWebsocketClientBuilder) RawQuery(rawQuery string) *SafeWebsocketCli
return b return b
} }
func (b *SafeWebsocketClientBuilder) Build() (*SafeWebsocketClient, error) { func (b *SafeWebsocketClientBuilder) ChannelSize(channelSize int64) *SafeWebsocketClientBuilder {
b.channelSize = &channelSize
return b
}
func (b *SafeWebsocketClientBuilder) Build(ctx context.Context) (*SafeWebsocketClient, error) {
if err := internal.NilChecker(b); err != nil { if err := internal.NilChecker(b); err != nil {
return nil, err return nil, err
} }
ctx, cancel := context.WithCancel(context.Background())
var useTLS bool var useTLS bool
if b.useTLS != nil { if b.useTLS != nil {
useTLS = *b.useTLS useTLS = *b.useTLS
} }
if b.channelSize == nil {
channelSize := int64(1)
b.channelSize = &channelSize
}
wsClient := SafeWebsocketClient{ wsClient := SafeWebsocketClient{
baseHost: *b.baseHost, baseHost: *b.baseHost,
basePort: *b.basePort, basePort: *b.basePort,
useTLS: useTLS, useTLS: useTLS,
path: b.path, path: b.path,
rawQuery: b.rawQuery, rawQuery: b.rawQuery,
ctx: ctx, dataChannel: make(chan []byte, *b.channelSize),
cancel: cancel,
dataChannel: make(chan []byte, 1),
mu: custom_rwmutex.NewCustomRwMutex(), mu: custom_rwmutex.NewCustomRwMutex(),
ctx: ctx,
reconnectCh: make(chan struct{}, 1), reconnectCh: make(chan struct{}, 1),
isConnected: false, isConnected: false,
doneMap: NewSafeMap[string, chan struct{}](),
} }
go wsClient.reconnectHandler()
if err := wsClient.connect(); err != nil { if err := wsClient.connect(); err != nil {
cancel()
return nil, fmt.Errorf("failed to establish initial connection: %v", err) return nil, fmt.Errorf("failed to establish initial connection: %v", err)
} }
@@ -97,10 +154,12 @@ type SafeWebsocketClient struct {
dataChannel chan []byte dataChannel chan []byte
mu *custom_rwmutex.CustomRwMutex mu *custom_rwmutex.CustomRwMutex
conn *websocket.Conn conn *websocket.Conn
cancelFuncs []context.CancelFunc
ctx context.Context ctx context.Context
cancel context.CancelFunc
reconnectCh chan struct{} reconnectCh chan struct{}
isConnected bool isConnected bool
doneMap *SafeMap[string, chan struct{}]
} }
func (wsClient *SafeWebsocketClient) connect() error { func (wsClient *SafeWebsocketClient) connect() error {
@@ -142,60 +201,80 @@ func (wsClient *SafeWebsocketClient) connect() error {
}) })
wsClient.mu.WriteHandler(func() error { wsClient.mu.WriteHandler(func() error {
if wsClient.conn != nil {
wsClient.conn.Close()
}
wsClient.conn = conn wsClient.conn = conn
wsClient.isConnected = true wsClient.isConnected = true
pingCtx, pingCancel := context.WithCancel(context.Background())
go wsClient.startPingTicker(pingCtx)
wsClient.cancelFuncs = append(wsClient.cancelFuncs, pingCancel)
receiverCtx, receiverCancel := context.WithCancel(context.Background())
go wsClient.startReceiveHandler(receiverCtx)
wsClient.cancelFuncs = append(wsClient.cancelFuncs, receiverCancel)
return nil return nil
}) })
go wsClient.startPingTicker()
go wsClient.startReceiveHandler()
go wsClient.reconnectHandler()
return nil return nil
} }
func (wsClient *SafeWebsocketClient) startPingTicker() { func (wsClient *SafeWebsocketClient) startPingTicker(ctx context.Context) {
ticker := time.NewTicker(pingPeriod) ticker := time.NewTicker(pingPeriod)
defer ticker.Stop() defer ticker.Stop()
for { for {
select { select {
case <-ctx.Done():
log.Println("ping ticker stopped")
return
case <-ticker.C: case <-ticker.C:
wsClient.mu.WriteHandler(func() error { wsClient.mu.WriteHandler(func() error {
if wsClient.conn == nil {
return fmt.Errorf("connection closed")
}
if err := wsClient.conn.WriteMessage(websocket.PingMessage, []byte{}); err != nil { if err := wsClient.conn.WriteMessage(websocket.PingMessage, []byte{}); err != nil {
log.Printf("Ping failed: %v. Will attempt reconnect.", err) log.Printf("Ping failed: %v. Will attempt reconnect.", err)
wsClient.triggerReconnect() wsClient.triggerReconnect()
} }
return nil return nil
}) })
case <-wsClient.ctx.Done():
log.Println("Ping ticker stopped")
return
} }
} }
} }
func (wsClient *SafeWebsocketClient) startReceiveHandler() { func (wsClient *SafeWebsocketClient) startReceiveHandler(ctx context.Context) {
for { for {
select { select {
case <-wsClient.reconnectCh: case <-ctx.Done():
case <-wsClient.ctx.Done(): log.Println("receive handler stopped")
log.Println("Reconnect handler stopped")
return return
default: default:
if err := wsClient.mu.ReadHandler(func() error { if err := wsClient.mu.ReadHandler(func() error {
conn := wsClient.conn conn := wsClient.conn
if conn == nil { if conn == nil {
return fmt.Errorf("no active connection, waiting for reconnect") wsClient.triggerReconnect()
return fmt.Errorf("connection closed")
} }
_, message, err := conn.ReadMessage() _, message, err := conn.ReadMessage()
if err != nil { if err != nil {
return err wsClient.triggerReconnect()
return fmt.Errorf("failed to read message: %v", err)
}
select {
case wsClient.dataChannel <- message:
case <-ctx.Done():
log.Println("Reconnect handler stopped")
return nil
default:
log.Println("Data channel full, dropping message")
} }
wsClient.dataChannel <- message
return nil return nil
}); err != nil { }); err != nil {
wsClient.triggerReconnect()
return return
} }
} }
@@ -210,11 +289,74 @@ func (wsClient *SafeWebsocketClient) triggerReconnect() {
} }
func (wsClient *SafeWebsocketClient) reconnectHandler() { func (wsClient *SafeWebsocketClient) reconnectHandler() {
for range wsClient.reconnectCh { backoff := 1 * time.Second
wsClient.connect() maxBackoff := 30 * time.Second
for {
select {
case <-wsClient.reconnectCh:
log.Println("Reconnect triggered")
if wsClient.cancelFuncs != nil {
for _, cancel := range wsClient.cancelFuncs {
cancel()
}
}
wsClient.isConnected = false
time.Sleep(100 * time.Millisecond)
isInnerLoop := true
for isInnerLoop {
log.Printf("Attempting reconnect in %v...", backoff)
select {
case <-time.After(backoff):
if err := wsClient.connect(); err != nil {
log.Printf("Reconnect failed: %v", err)
if backoff < maxBackoff {
backoff *= 2
}
continue
}
log.Println("Reconnected successfully")
backoff = 1 * time.Second
isInnerLoop = false
continue
case <-wsClient.ctx.Done():
return
}
}
case <-wsClient.ctx.Done():
log.Println("reconnect handler stopped due to client shutdown")
wsClient.Close()
return
}
} }
} }
func (wsClient *SafeWebsocketClient) DataChannel() <-chan []byte { func (wsClient *SafeWebsocketClient) DataChannel() <-chan []byte {
return wsClient.dataChannel return wsClient.dataChannel
} }
func (wsClient *SafeWebsocketClient) WriteJSON(message any) error {
return wsClient.mu.WriteHandler(func() error {
return wsClient.conn.WriteJSON(message)
})
}
func (wsClient *SafeWebsocketClient) Close() error {
wsClient.mu.WriteHandler(func() error {
if wsClient.cancelFuncs != nil {
for _, cancel := range wsClient.cancelFuncs {
cancel()
}
}
if wsClient.conn != nil {
wsClient.conn.Close()
}
wsClient.isConnected = false
return nil
})
close(wsClient.dataChannel)
return nil
}

View File

@@ -1,22 +1,39 @@
package main package main
import ( import (
"context"
"fmt" "fmt"
"log" "log"
"os"
"os/signal"
"syscall"
"git.neurocipta.com/rogerferdinan/safe-web-socket/v1/client" "git.neurocipta.com/rogerferdinan/safe-web-socket/v1/client"
) )
func main() { func main() {
sigChan := make(chan os.Signal, 1)
signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
<-sigChan
fmt.Println("\nReceived interrupt signal. Shutting down gracefully...")
cancel()
}()
wsClient, err := client.NewSafeWebsocketClientBuilder(). wsClient, err := client.NewSafeWebsocketClientBuilder().
BaseHost("localhost"). BaseHost("localhost").
BasePort(8080). BasePort(8080).
Path("/ws/test/data_1"). Path("/ws/test/data_1").
UseTLS(false). UseTLS(false).
Build() Build(ctx)
if err != nil { if err != nil {
log.Fatal(err) log.Fatal(err)
} }
dataChannel := wsClient.DataChannel() dataChannel := wsClient.DataChannel()
for data := range dataChannel { for data := range dataChannel {