Compare commits

...

16 Commits

Author SHA1 Message Date
967b8a98b3 fix: write & reader posiiton 2025-09-30 07:12:38 +07:00
d09d389011 fix: initialize write channel 2025-09-30 06:59:01 +07:00
c550701dfa fix: adding lock for cancel function slices 2025-09-29 22:53:29 +07:00
2225391fc3 fix: changing to one concurrent writer & reader 2025-09-29 22:47:33 +07:00
9f8ee49b5c fix: adding SafeWebSocketClient parameter 2025-09-29 18:48:38 +07:00
735f55858e fix: adding nil checker 2025-09-29 17:58:19 +07:00
5e5df9090f fix: adding back read mutex for data race 2025-09-29 17:55:24 +07:00
1537e58444 fix: fixing deadlock caused by read mutex 2025-09-29 16:38:08 +07:00
66b27082b9 feat: adding reconnect channel for authentication purposes 2025-09-29 15:45:02 +07:00
9d74e72ede feat: add writeJSON function 2025-09-29 14:40:07 +07:00
dfbe2f2808 fix: fixing client deadlock condition & reconnection issues 2025-09-29 09:06:31 +07:00
4792d638c1 feat: adding channelSize to safe websocket client 2025-09-27 05:27:57 +07:00
b96e574726 feat: adding client close function 2025-09-27 04:52:47 +07:00
752804cc58 fix: restructuring safe websocket client 2025-09-27 04:48:01 +07:00
e686e69a24 fix: fixing client nil pointer 2025-09-26 16:10:19 +07:00
034e5b68e0 fix: client reconnection data race fix 2025-09-26 16:07:20 +07:00
2 changed files with 366 additions and 83 deletions

View File

@@ -3,9 +3,11 @@ package client
import (
"context"
"fmt"
"io"
"log"
"net/url"
"strings"
"sync"
"time"
custom_rwmutex "git.neurocipta.com/rogerferdinan/custom-rwmutex"
@@ -14,15 +16,78 @@ import (
)
const (
pingPeriod = 10 * time.Second
pingPeriod = 10 * time.Second
readDeadline = 10 * time.Second
)
type SafeMap[K comparable, V any] struct {
m sync.Map
}
func NewSafeMap[K comparable, V any]() *SafeMap[K, V] {
return &SafeMap[K, V]{
m: sync.Map{},
}
}
func (sm *SafeMap[K, V]) Store(key K, value V) {
sm.m.Store(key, value)
}
func (sm *SafeMap[K, V]) Load(key K) (value V, ok bool) {
val, loaded := sm.m.Load(key)
if !loaded {
return *new(V), false
}
return val.(V), true
}
func (sm *SafeMap[K, V]) Delete(key K) {
sm.m.Delete(key)
}
func (sm *SafeMap[K, V]) Range(f func(K, V) bool) {
sm.m.Range(func(key, value any) bool {
k, ok1 := key.(K)
v, ok2 := value.(V)
if !ok1 || !ok2 {
return true
}
return f(k, v)
})
}
func (sm *SafeMap[K, V]) Len() int {
count := 0
sm.Range(func(_ K, _ V) bool {
count++
return true
})
return count
}
type MessageType uint
const (
MessageTypeText MessageType = iota + 1
MessageTypePing MessageType = iota
MessageTypePong MessageType = iota
MessageTypeClose MessageType = iota
)
type Message struct {
MessageType MessageType
Data []byte
}
type SafeWebsocketClientBuilder struct {
baseHost *string `nil_checker:"required"`
basePort *uint16 `nil_checker:"required"`
path *string
rawQuery *string
useTLS *bool
baseHost *string `nil_checker:"required"`
basePort *uint16 `nil_checker:"required"`
path *string
rawQuery *string
useTLS *bool
channelSize *int64
authenticateFn func(*SafeWebsocketClient) error
}
func NewSafeWebsocketClientBuilder() *SafeWebsocketClientBuilder {
@@ -44,6 +109,11 @@ func (b *SafeWebsocketClientBuilder) UseTLS(useTLS bool) *SafeWebsocketClientBui
return b
}
func (b *SafeWebsocketClientBuilder) AuthenticateFn(authenticateFn func(*SafeWebsocketClient) error) *SafeWebsocketClientBuilder {
b.authenticateFn = authenticateFn
return b
}
func (b *SafeWebsocketClientBuilder) Path(path string) *SafeWebsocketClientBuilder {
b.path = &path
return b
@@ -54,7 +124,12 @@ func (b *SafeWebsocketClientBuilder) RawQuery(rawQuery string) *SafeWebsocketCli
return b
}
func (b *SafeWebsocketClientBuilder) Build() (*SafeWebsocketClient, error) {
func (b *SafeWebsocketClientBuilder) ChannelSize(channelSize int64) *SafeWebsocketClientBuilder {
b.channelSize = &channelSize
return b
}
func (b *SafeWebsocketClientBuilder) Build(ctx context.Context) (*SafeWebsocketClient, error) {
if err := internal.NilChecker(b); err != nil {
return nil, err
}
@@ -64,18 +139,32 @@ func (b *SafeWebsocketClientBuilder) Build() (*SafeWebsocketClient, error) {
useTLS = *b.useTLS
}
if b.channelSize == nil {
channelSize := int64(1)
b.channelSize = &channelSize
}
wsClient := SafeWebsocketClient{
baseHost: *b.baseHost,
basePort: *b.basePort,
useTLS: useTLS,
path: b.path,
rawQuery: b.rawQuery,
dataChannel: make(chan []byte, 1),
dataChannel: make(chan []byte, *b.channelSize),
mu: custom_rwmutex.NewCustomRwMutex(),
ctx: ctx,
reconnectCh: make(chan struct{}, 1),
isConnected: false,
doneMap: NewSafeMap[string, chan struct{}](),
writeChan: make(chan Message),
}
if b.authenticateFn != nil {
wsClient.authenticateFn = b.authenticateFn
}
go wsClient.reconnectHandler()
if err := wsClient.connect(); err != nil {
return nil, fmt.Errorf("failed to establish initial connection: %v", err)
}
@@ -84,18 +173,27 @@ func (b *SafeWebsocketClientBuilder) Build() (*SafeWebsocketClient, error) {
}
type SafeWebsocketClient struct {
baseHost string
basePort uint16
useTLS bool
path *string
rawQuery *string
baseHost string
basePort uint16
useTLS bool
path *string
rawQuery *string
dataChannel chan []byte
mu *custom_rwmutex.CustomRwMutex
conn *websocket.Conn
ctx context.Context
cancel context.CancelFunc
reconnectCh chan struct{}
isConnected bool
cancelFuncs []context.CancelFunc
ctx context.Context
Cancel context.CancelFunc
reconnectCh chan struct{}
reconnectChans []chan struct{}
isConnected bool
doneMap *SafeMap[string, chan struct{}]
authenticateFn func(*SafeWebsocketClient) error
writeChan chan Message
}
func (wsClient *SafeWebsocketClient) connect() error {
@@ -124,87 +222,163 @@ func (wsClient *SafeWebsocketClient) connect() error {
}
conn.SetPingHandler(func(pingData string) error {
return wsClient.mu.WriteHandler(func() error {
if err := conn.WriteMessage(websocket.PongMessage, []byte(pingData)); err != nil {
if err == websocket.ErrCloseSent {
return nil
}
if netErr, ok := err.(interface{ Timeout() bool }); ok && netErr.Timeout() {
return nil
}
return err
if err := conn.WriteMessage(websocket.PongMessage, []byte(pingData)); err != nil {
if err == websocket.ErrCloseSent {
return nil
}
return nil
})
})
wsClient.mu.WriteHandler(func() error {
ctx, cancel := context.WithCancel(context.Background())
wsClient.ctx = ctx
wsClient.cancel = cancel
wsClient.conn = conn
wsClient.isConnected = true
if netErr, ok := err.(interface{ Timeout() bool }); ok && netErr.Timeout() {
return nil
}
return err
}
return nil
})
go wsClient.startPingTicker()
go wsClient.startReceiveHandler()
go wsClient.reconnectHandler()
pingCtx, pingCancel := context.WithCancel(context.Background())
go wsClient.startPingTicker(pingCtx)
wsClient.mu.WriteHandler(func() error {
wsClient.cancelFuncs = append(wsClient.cancelFuncs, pingCancel)
return nil
})
if wsClient.conn != nil {
wsClient.conn.Close()
}
wsClient.conn = conn
wsClient.isConnected = true
if wsClient.authenticateFn != nil {
if err := wsClient.authenticateFn(wsClient); err != nil {
return err
}
}
go func() {
ctx, cancel := context.WithCancel(context.Background())
wsClient.mu.WriteHandler(func() error {
wsClient.cancelFuncs = append(wsClient.cancelFuncs, cancel)
return nil
})
writer, err := conn.NextWriter(websocket.TextMessage)
if err != nil {
return
}
for {
select {
case <-ctx.Done():
fmt.Println("Writer stopped due to client shutdown")
return
case data := <-wsClient.writeChan:
if conn == nil {
wsClient.triggerReconnect()
return
}
if _, err := writer.Write(data.Data); err != nil {
return
}
}
}
}()
go func() {
ctx, cancel := context.WithCancel(context.Background())
wsClient.mu.WriteHandler(func() error {
wsClient.cancelFuncs = append(wsClient.cancelFuncs, cancel)
return nil
})
_, reader, err := conn.NextReader()
if err != nil {
return
}
for {
select {
case <-ctx.Done():
fmt.Println("Reader stopped due to client shutdown")
return
default:
if conn == nil {
return
}
if err := conn.SetReadDeadline(time.Now().Add(readDeadline)); err != nil {
fmt.Printf("error on read deadline: %v\n", err)
return
}
readerBytes, err := io.ReadAll(reader)
if err != nil {
fmt.Printf("io reader failed: %v\n", err)
wsClient.triggerReconnect()
return
}
select {
case wsClient.dataChannel <- readerBytes:
case <-ctx.Done():
return
default:
fmt.Println("Data channel full, dropping message")
}
}
}
}()
return nil
}
func (wsClient *SafeWebsocketClient) startPingTicker() {
func (wsClient *SafeWebsocketClient) startPingTicker(ctx context.Context) {
ticker := time.NewTicker(pingPeriod)
defer ticker.Stop()
for {
select {
case <-ctx.Done():
log.Println("ping ticker stopped")
return
case <-ticker.C:
wsClient.mu.WriteHandler(func() error {
if err := wsClient.conn.WriteMessage(websocket.PingMessage, []byte{}); err != nil {
log.Printf("Ping failed: %v. Will attempt reconnect.", err)
wsClient.triggerReconnect()
}
return nil
})
case <-wsClient.ctx.Done():
log.Println("Ping ticker stopped")
return
wsClient.writeChan <- Message{
MessageType: websocket.PingMessage,
Data: nil,
}
}
}
}
func (wsClient *SafeWebsocketClient) startReceiveHandler() {
for {
select {
case <-wsClient.ctx.Done():
log.Println("Reconnect handler stopped")
return
default:
// if err := wsClient.mu.ReadHandler(func() error {
conn := wsClient.conn
// func (wsClient *SafeWebsocketClient) startReceiveHandler(ctx context.Context) {
// for {
// select {
// case <-ctx.Done():
// log.Println("receive handler stopped")
// return
// default:
// if err := wsClient.mu.ReadHandler(func() error {
// conn := wsClient.conn
if conn == nil {
wsClient.triggerReconnect()
return
// return fmt.Errorf("no active connection, waiting for reconnect")
}
_, message, err := conn.ReadMessage()
if err != nil {
wsClient.triggerReconnect()
return
// return err
}
wsClient.dataChannel <- message
// return nil
// }); err != nil {
// wsClient.triggerReconnect()
// return
// }
}
}
}
// if conn == nil {
// wsClient.triggerReconnect()
// return fmt.Errorf("connection closed")
// }
// _, message, err := conn.ReadMessage()
// if err != nil {
// wsClient.triggerReconnect()
// return fmt.Errorf("failed to read message: %v", err)
// }
// select {
// case wsClient.dataChannel <- message:
// case <-ctx.Done():
// log.Println("Reconnect handler stopped")
// default:
// log.Println("")
// }
// return nil
// }); err != nil {
// return
// }
// }
// }
// }
func (wsClient *SafeWebsocketClient) triggerReconnect() {
select {
@@ -214,17 +388,102 @@ func (wsClient *SafeWebsocketClient) triggerReconnect() {
}
func (wsClient *SafeWebsocketClient) reconnectHandler() {
backoff := 1 * time.Second
maxBackoff := 30 * time.Second
for {
select {
case <-wsClient.reconnectCh:
wsClient.cancel()
wsClient.connect()
log.Println("Reconnect triggered")
wsClient.mu.ReadHandler(func() error {
if wsClient.cancelFuncs != nil {
for _, cancel := range wsClient.cancelFuncs {
cancel()
}
}
return nil
})
wsClient.isConnected = false
time.Sleep(100 * time.Millisecond)
isInnerLoop := true
for isInnerLoop {
log.Printf("Attempting reconnect in %v...", backoff)
select {
case <-time.After(backoff):
if err := wsClient.connect(); err != nil {
log.Printf("Reconnect failed: %v", err)
if backoff < maxBackoff {
backoff *= 2
}
continue
}
log.Println("Reconnected successfully")
backoff = 1 * time.Second
isInnerLoop = false
continue
case <-wsClient.ctx.Done():
log.Println("reconnect handler stopped due to client shutdown")
wsClient.Close()
return
}
}
if wsClient.reconnectChans != nil {
for _, reconnectCh := range wsClient.reconnectChans {
reconnectCh <- struct{}{}
}
}
case <-wsClient.ctx.Done():
log.Println("reconnect handler stopped due to client shutdown")
wsClient.Close()
return
}
}
}
func (wsClient *SafeWebsocketClient) ReconnectChannel() <-chan struct{} {
reconnectCh := make(chan struct{})
wsClient.mu.WriteHandler(func() error {
wsClient.reconnectChans = append(wsClient.reconnectChans, reconnectCh)
return nil
})
return reconnectCh
}
func (wsClient *SafeWebsocketClient) DataChannel() <-chan []byte {
return wsClient.dataChannel
}
func (wsClient *SafeWebsocketClient) Write(data []byte) error {
wsClient.writeChan <- Message{
MessageType: MessageTypeText,
Data: data,
}
return nil
}
func (wsClient *SafeWebsocketClient) Close() error {
wsClient.mu.ReadHandler(func() error {
if wsClient.cancelFuncs != nil {
for _, cancel := range wsClient.cancelFuncs {
cancel()
}
}
return nil
})
if wsClient.reconnectChans != nil {
for _, reconnectChan := range wsClient.reconnectChans {
close(reconnectChan)
}
}
if wsClient.conn != nil {
wsClient.conn.Close()
}
wsClient.isConnected = false
close(wsClient.dataChannel)
return nil
}

View File

@@ -1,25 +1,49 @@
package main
import (
"context"
"fmt"
"log"
"os"
"os/signal"
"syscall"
"git.neurocipta.com/rogerferdinan/safe-web-socket/v1/client"
)
func main() {
sigChan := make(chan os.Signal, 1)
signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
go func() {
<-sigChan
fmt.Println("\nReceived interrupt signal. Shutting down gracefully...")
cancel()
}()
wsClient, err := client.NewSafeWebsocketClientBuilder().
BaseHost("localhost").
BasePort(8080).
Path("/ws/test/data_1").
UseTLS(false).
Build()
Build(ctx)
if err != nil {
log.Fatal(err)
}
go func() {
for range wsClient.ReconnectChannel() {
fmt.Println("Reconnection Success")
}
}()
dataChannel := wsClient.DataChannel()
for data := range dataChannel {
// _ = data
fmt.Println(string(data))
}
}